Remove test flakiness via dependency injection#8
Merged
Conversation
Replace process.env mutation in client.test.ts and process.stdout.isTTY mutation in format.test.ts with pure dependency injection. Add optional env parameter to resolveConnectionConfig and isTTY parameter to resolveFormat, both defaulting to their original runtime behavior. Eliminates beforeEach/afterEach save/restore overhead and Object.defineProperty hacks, making tests deterministic with zero global state pollution. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate test flakiness by making unit tests pure and deterministic. Replace global state mutation (process.env save/restore, process.stdout.isTTY manipulation) with dependency injection parameters.
Changes:
envparameter toresolveConnectionConfig()(defaults toprocess.env)isTTYparameter toresolveFormat()(defaults toprocess.stdout.isTTY)client.test.tsto pass env objects directly instead of mutatingprocess.envformat.test.tsto pass boolean flags instead of mutatingprocess.stdoutwithObject.definePropertyTests are now fully deterministic with zero global state pollution. Existing call sites remain backward-compatible.
🤖 Generated with Claude Code