Fix env add: validate input and verify connection#10
Merged
Conversation
Adds input validation (requires --host or --url), connection verification with automatic HTTPS detection, and a --no-verify flag to skip verification. Fixes missing await in test assertion and double client.close() in catch block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The first argument to resolveConnectionConfig expects CliConfig which has
required fields. Cast {} as CliConfig since only the named environment
is needed for connection verification.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env addrequiring at least--hostor--url--no-verifyflag to skip connection verificationawaitonexpect().rejects.toThrow()in testsclient.close()call (removed from catch block, kept in finally)Test plan
env addrejects environments with no host or url--no-verifyto avoid real connections🤖 Generated with Claude Code