Open
Conversation
|
Code Climate has analyzed commit a6b11ae and detected 0 issues on this pull request. View more on Code Climate. |
Babacooll
reviewed
Apr 19, 2019
| } | ||
| } | ||
|
|
||
| class FixtureEvent extends GenericEvent |
There was a problem hiding this comment.
Correct me if I'm wrong but we don't support PHP 5.6 anymore or do we ? Because if so, it would be cleaner to use anonymous classes here.
Contributor
Author
There was a problem hiding this comment.
I unfortunately disagree with u, as our spielplatz is on 5.6 we have to be able to deploy to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to be able to use autowired service as event listener. As discussed with Joel we are not implementing autowiring detection in service manager
has()method but explicitly in eventmanager itself