Open
Conversation
This was referenced Mar 1, 2017
antoinerobin
reviewed
Mar 2, 2017
Contributor
antoinerobin
left a comment
There was a problem hiding this comment.
Shouldn't we have something that automatically jsonify the cache when it is a redis cache in order to avoid mistakes ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FULL PR SET IS
#311
oat-sa/tao-core#1212
oat-sa/extension-tao-outcome#65
oat-sa/extension-tao-outcomeui#92
This PR enables the KeyValueCache to use Redis as its storage. Without this, we are not able to share the generis cache efficiently amongst servers, which is a show stopper for the TAO Cloud. Indeed, as funcAcls, roles, ... are depending on the cache, it seems obvious it has to be shared amongst web servers to provide large-scale authoring platforms (a.k.a. backoffice).
This is amazing how your TAO platform will be more reactive than ever, especially when entering the Item Authoring or taking a Delivery.
I'm aware that it might not work with all projects (ACT ?), but with TAO Vanilla it does pretty well! However, it's a config to change so no impact is expected. I will dig further on every project to see how feasible it is to go to KeyValueCache using Redis for customer projects.
In order to enable the KeyValueCache in redis:
config/generis/cache.conf.phpfile to