Skip to content

fix: add a fix to cover infinity recursive call#1139

Open
shpran wants to merge 1 commit intodevelopfrom
fix/improve-get-parent-classes-id-call
Open

fix: add a fix to cover infinity recursive call#1139
shpran wants to merge 1 commit intodevelopfrom
fix/improve-get-parent-classes-id-call

Conversation

@shpran
Copy link
Contributor

@shpran shpran commented Nov 14, 2024

Goal

Use getParentClassesIds recursive call in isInstanceOf method to improve performance.

Issue

When using isInstanceOf with getParentClassesIds recursive call on properties, it stuck due to infinity recursive call, because http://www.w3.org/2000/01/rdf-schema#Class type points to itself.

TODO

  • Check other types of resources to be compatible with new solution

@shpran shpran requested a review from gabrielfs7 November 14, 2024 11:49
@github-actions
Copy link

Version

Target Version 15.39.2
Last version 15.39.1

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@shpran shpran marked this pull request as draft November 14, 2024 11:51
@gabrielfs7 gabrielfs7 marked this pull request as ready for review December 12, 2024 11:32
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks @shpran

Before merge we need to ask QA

Copy link
Contributor

@tikhanovichA tikhanovichA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants