fix(engine, ontology): review orchestrator#47
Merged
Conversation
Move DocumentEnvelope from context/ to its own envelope/ module and introduce ApplyPatch — a trait for merging operation results back into the envelope. Concrete patch types: DetectedEntities, RefinedEntities, PolicyOutcome, OperationEntry. Supports tuples for composite returns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Detection operations (NER, CV, OcrVerification, PatternMatch) now return DetectedEntities; refinement operations (Deduplication, Ensemble) return RefinedEntities; EvaluatePolicy returns PolicyOutcome instead of the removed EvaluatePolicyOutput. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…, and methods Add new EntityKind variants (VehicleId, LicensePlate, CardExpiry, BankRouting, SwiftCode, CryptoAddress, Amount, InsuranceId, PrescriptionId, Medication, FacialGeometry, Voiceprint, RetinaScan, AuthToken, PrivateKey, DeviceId, GeolocationMetadata, Handwriting, Logo, Barcode, DepartmentName, FacilityName, CaseNumber, InternalId, DateTime). Add EntityCategory::Visual. Expand ExtractionMethod and RecognitionMethod with new variants. Update sensitivity and category mappings, pattern assets, and all downstream consumers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Dictionaries: add filesystem loading (from_path, load_file, load_dir), DictionaryLoadError type, make module public with registry re-exports. Validators: expand Luhn tests, improve module docs. Patterns: add tracing target constants, improve context rule docs. Engine: fix scan_deny_list borrow issue with HashSet, add assert guard for empty recognition_methods, use BTreeMap in DenyList for determinism, add tracing targets and field recording throughout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…kspace Use self:: prefix on all pub use re-exports in mod.rs and lib.rs files to visually distinguish internal submodule imports from external crate imports. Applied consistently across all workspace crates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
martsokha
added
docs
…lish docs Move allow/deny lists from PatternEngine into per-scan ScanContext, simplify DenyList::with/insert to take a DenyRule struct instead of separate fields, remove FromIterator for DenyList, fold builder back into its own file after slimming, add scan_context.rs. Extract registries and error types into dedicated files across dictionaries and patterns modules. Rename Error.source_component to component. Normalize all doc comments to prefer : over — and single spaces. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… naming Add tracing instrumentation to all public methods, .with_component() on all errors, #![forbid(unsafe_code)] and docsrs attributes. Split flat store/ module into handler/ (ContentHandle, ContextHandle) and registry/ (Registry). Deduplicate composite key construction and prefix-scan helpers. Rename parameters to use _id suffix (actor_id, content_id, context_id) and document all types, fields, and methods. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the free-function NER, OCR, and transcription modules and introduce a structured ExifModule that takes ContentData (arc-backed, zero-copy) and ExifParams (Copy). Add tracing instrumentation to PythonBridge and ExifModule, improve docs, and clean up error messages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
martsokha
changed the title
martsokha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.