This repository was archived by the owner on Jun 11, 2020. It is now read-only.
Don't ask again on close#115
Open
zimnx wants to merge 2 commits intonurupo:masterfrom
zimnx:on-close=acceptance
Open
Don't ask again on close#115zimnx wants to merge 2 commits intonurupo:masterfrom zimnx:on-close=acceptance
zimnx wants to merge 2 commits intonurupo:masterfrom
zimnx:on-close=acceptance
Conversation
…oseAplicationDialog which indicates if window shoud appear in future
…same line as buttons
Contributor
Author
Owner
|
That is kind of funny, because the close application dialog served as a work around for several things:
So it's as if you made a workaround for a workaround : ) I will look into it and probably will end up implementing the offline status the right way and removing this annoying CloseApplicationDialog at all. |
Contributor
Author
|
I didn't know that, i saw comment near changing status to offline, but i thought that this window will be integrated part of Tox, some applications use this pattern when closeing ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hey


i added checkbox which can user use to determine if he want confrimation dialog when closing application.
Checbox can be checked in Settings page or directly on dialog.
Here is how it looks now:
I also centered buttons because with checkbox when they were aligned to right whole dialog looked ugly.
Maybe checkbox should be in the same line with buttons. What do you think?
Change in settings page:
I also fixed tray label. When user minimized window by clicking on close button, tray had label "hide" instead of "show"