Skip to content

fix so that commands with && > | these operator work#2

Open
rogdevil wants to merge 1 commit intomainfrom
fix/bashCmd
Open

fix so that commands with && > | these operator work#2
rogdevil wants to merge 1 commit intomainfrom
fix/bashCmd

Conversation

@rogdevil
Copy link
Contributor

previously if we had to run commad like
echo "/** @type {import('next').NextConfig} */" > next.config.js or
cd project && npm i
these won't work as exec.Command does not store standard output or standard err it a command fail it simply retuns an error thus causing us problem with yml files where we need to do custom nginx file addition or configuration file changes.
fix is to treat each command as a bash command as whole.

@rogdevil rogdevil requested a review from euforia October 25, 2023 16:19
Copy link
Collaborator

@euforia euforia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing pipes and redirects is a larger concern

@rogdevil
Copy link
Contributor Author

Yeah we need these when we need to append to a file like we needed in next.conf.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants