Add server-side tests for the Ring handler#50
Merged
Conversation
bbatsov
force-pushed
the
add-core-handler-tests
branch
from
507a468 to
5f8bf81
Compare
The test suite only covered eval round-trips through a real Jetty server via drawbridge.client-test. This adds direct Ring-level tests for the handler returned by ring-handler, covering method rejection, GET-with-op rejection, eval responses, session persistence, custom cookie names, and custom nREPL handlers.
bbatsov
force-pushed
the
add-core-handler-tests
branch
from
5f8bf81 to
184b300
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite only had
drawbridge.client-testcovering eval round-trips through a real Jetty server. This addsdrawbridge.core-testthat tests the ring handler directly with Ring request maps — faster, more focused, and isolates server logic from transport concerns.Covers method rejection (PUT/DELETE/PATCH), GET-with-op rejection, empty GET responses, POST eval, session persistence, custom
:cookie-name, and custom:nrepl-handler. All passing across Clojure 1.10, 1.11, and 1.12.