Conversation
owlstronaut
commented
Feb 25, 2026
- feat: use node:crypto instead of imurmurhash
- deps: remove imurmurhash
|
iirc imurmurhash was picked for performance reasons
We may want to do a quick benchmark to make sure we're not getting wildly out of frame here. |
|
That sounds like a fun experiment :) |
|
I ran some benchmarks on this. imurmurhash is faster, but the difference is negligible:
For unique-slug (which I'd also like to make this change in), cacache calls it once per content write. Even on a large install with 1,000 packages, the total I think using this hash originally was a hobbyist optimization |
wraithgar
left a comment
There was a problem hiding this comment.
nit: this is a fix not a feat imvhmo
9f46cbf to
e5219a8
Compare
🤖 I have created a release *beep* *boop* --- ## [7.0.1](v7.0.0...v7.0.1) (2026-02-26) ### Bug Fixes * [`da246ef`](da246ef) [#229](#229) use node:crypto instead of imurmurhash (@owlstronaut) ### Dependencies * [`727e92c`](727e92c) [#229](#229) remove imurmurhash ### Chores * [`4785863`](4785863) [#221](#221) bump @npmcli/eslint-config from 5.1.0 to 6.0.0 (#221) (@dependabot[bot]) * [`0c819a3`](0c819a3) [#223](#223) bump @npmcli/template-oss from 4.28.0 to 4.28.1 (#223) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>