Skip to content

Fix address int64#9

Open
Kenzzer wants to merge 1 commit intonosoop:masterfrom
Kenzzer:fix_address
Open

Fix address int64#9
Kenzzer wants to merge 1 commit intonosoop:masterfrom
Kenzzer:fix_address

Conversation

@Kenzzer
Copy link
Copy Markdown

@Kenzzer Kenzzer commented Apr 2, 2026

No description provided.

@nosoop
Copy link
Copy Markdown
Owner

nosoop commented Apr 3, 2026

It's good to be proactive on this, but I'm not really keen on chasing unstable API on this project (even if the project itself touts "just vendor it lol"). Behold, nosoop/SM-TFEconData#32.

I'd be open to spawning an x64 branch if you want some "official" repo to pin compile deps to, but otherwise I'll just leave this open until it lands in stable.

* @param addr Address to a memory location.
* @return The value stored in the given address as an Address.
*/
stock Address DereferencePointer(Address addr) {
Copy link
Copy Markdown
Owner

@nosoop nosoop Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#pragma deprecated still works, yeah? We can keep the alias to LoadAddressFromAddress for this but warn on DereferencePointer usage. Most consumers of this are going to need additional rewrites in any case, so I think it's worth discouraging usage of this in favor of the official API.

@Kenzzer
Copy link
Copy Markdown
Author

Kenzzer commented Apr 3, 2026

Alright let's keep this MR opened for now. See you in a (few?) years when SM 1.13 lands stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants