Update task card interactivity with Turbo Streams#167
Open
fujiwara-e wants to merge 3 commits intonomlab:mainfrom
Open
Update task card interactivity with Turbo Streams#167fujiwara-e wants to merge 3 commits intonomlab:mainfrom
fujiwara-e wants to merge 3 commits intonomlab:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
タスク一覧画面のカード上で状態変更(PATCH)した際に Content missing が出る問題を、Turbo Streams を用いてカード部分だけ差し替えることで解消するPRです。
Changes:
TasksController#updateに Turbo Stream 応答(update.turbo_stream)を追加- タスクカードの描画を Turbo Frame 単位で置換できるようにし、更新時に該当カードのみ差し替え
- 完了状態の見た目変化を滑らかにするため、opacity の transition を追加
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/controllers/tasks_controller.rb | update の Turbo Stream 応答を追加し、カード更新をストリームで返す |
| app/views/tasks/update.turbo_stream.erb | task_card_* を turbo_stream.replace で差し替えるテンプレートを追加 |
| app/views/tasks/_task.html.erb | タスクカード全体を turbo_frame_tag("task_card_*") でラップし、差し替え対象を統一 |
| app/assets/stylesheets/tasks.scss | 完了/未完了切替時の opacity 変化に transition を付与 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
タスク一覧画面のカードで,タスクの状態を変更すると
Content missingと表示されるバグを修正.原因は,
TasksControllerのupdateアクションでformat.turbo_streamハンドラが実装されていなかったこと.変更点
updateアクションにformat.turbo_streamハンドラを追加.