Skip to content

test_runner: omit ignored uncovered branches in lcov#62360

Closed
ace-tk wants to merge 1 commit intonodejs:mainfrom
ace-tk:fix/test-runner-lcov-ignore-branches
Closed

test_runner: omit ignored uncovered branches in lcov#62360
ace-tk wants to merge 1 commit intonodejs:mainfrom
ace-tk:fix/test-runner-lcov-ignore-branches

Conversation

@ace-tk
Copy link

@ace-tk ace-tk commented Mar 21, 2026

Summary

  • omit uncovered BRDA entries in lcov when branch maps to ignored node:coverage lines
  • compute BRF/BRH from emitted BRDA entries so lcov totals stay consistent
  • add a regression fixture/test for ignored-branch behavior in lcov reporter

Test plan

  • not run in this environment (missing out/Release/node)
  • run: python3 tools/test.py test/parallel/test-runner-coverage.js

Ignored `node:coverage` regions should not generate uncovered BRDA entries in lcov output. Align branch summaries with emitted BRDA lines and add a regression test fixture.

Made-with: Cursor
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 21, 2026
@JakobJingleheimer JakobJingleheimer added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Mar 21, 2026
@JakobJingleheimer
Copy link
Member

Duplicate of #61598

@JakobJingleheimer JakobJingleheimer marked this as a duplicate of #61598 Mar 21, 2026
@ace-tk ace-tk closed this Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate Issues and PRs that are duplicates of other issues or PRs. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants