tools: add eslint-plugin-regexp#62093
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 18, 2026
Merged
Conversation
JLHwung
commented
Mar 3, 2026
| 'regexp/no-misleading-capturing-group': 'off', | ||
| 'regexp/no-obscure-range': 'off', | ||
| 'regexp/no-potentially-useless-backreference': 'off', | ||
| 'regexp/no-super-linear-backtracking': 'off', |
Contributor
Author
There was a problem hiding this comment.
This rule can prevent issues like #61904.
Contributor
Author
There was a problem hiding this comment.
Shouldn't this be
errorthen?
Per PR description
To seek consensus on whether we should use this plugin, we have disabled all rules which the current codebase does not meet, so there is no change in the current codebase.
There are around 20 errors from this rule, to limit the scope of this PR, I suggest we discuss whether we should add this eslint plugin. If there is a consensus to add it, then we can always open a new PR to enable rules and fix linting errors.
aduh95
approved these changes
Mar 17, 2026
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I don't see why not. There are conflicts to resolve though
JLHwung
force-pushed
the
add-eslint-plugin-regexp
branch
from
06e5140 to
87076ee
Compare
targos
approved these changes
Mar 18, 2026
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in bd8522a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add
eslint-plugin-regexpand its recommended rule set to the current lint rule. To seek consensus on whether we should use this plugin, we have disabled all rules which the current codebase does not meet, so there is no change in the current codebase. I plan to enable some of them in the near future if we agree to add this eslint plugin.