Skip to content

crypto: rename CShakeParams and KmacParams length to outputLength#61875

Closed
panva wants to merge 1 commit intonodejs:mainfrom
panva:modern-updates
Closed

crypto: rename CShakeParams and KmacParams length to outputLength#61875
panva wants to merge 1 commit intonodejs:mainfrom
panva:modern-updates

Conversation

@panva
Copy link
Member

@panva panva commented Feb 18, 2026

Aligns the implementation of CShakeParams and KmacParams dictionaries with a change made in https://redirect.github.com/WICG/webcrypto-modern-algos/pull/52

Documentation diff is due to keeping the attributes in a dictionary order.

Note that these are both experimental Issues and PRs related to experimental features. .

Refs: web-platform-tests/wpt#57802

@panva panva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. webcrypto labels Feb 18, 2026
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 18, 2026
@panva panva marked this pull request as ready for review February 18, 2026 11:22
@panva panva added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lts-watch-v24.x PRs that may need to be released in v24.x labels Feb 18, 2026
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.67%. Comparing base (4579957) to head (e645d2d).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/crypto/webidl.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #61875   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files         676      676           
  Lines      206555   206555           
  Branches    39554    39552    -2     
=======================================
+ Hits       185230   185237    +7     
+ Misses      13461    13447   -14     
- Partials     7864     7871    +7     
Files with missing lines Coverage Δ
lib/internal/crypto/hash.js 98.93% <100.00%> (ø)
lib/internal/crypto/mac.js 91.12% <100.00%> (ø)
lib/internal/crypto/webidl.js 98.33% <75.00%> (ø)

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva changed the title crypto: rename cSHAKEParams and KmacParams length to outputLength crypto: rename CSHAKEParams and KmacParams length to outputLength Feb 18, 2026
@panva panva changed the title crypto: rename CSHAKEParams and KmacParams length to outputLength crypto: rename CShakeParams and KmacParams length to outputLength Feb 18, 2026
@panva panva added the review wanted PRs that need reviews. label Feb 23, 2026
@panva
Copy link
Member Author

panva commented Mar 1, 2026

ping @nodejs/crypto

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@panva panva added review wanted PRs that need reviews. and removed review wanted PRs that need reviews. labels Mar 9, 2026
@panva
Copy link
Member Author

panva commented Mar 10, 2026

At this point we might as well wait for the WPT update web-platform-tests/wpt#57802

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Mar 10, 2026
@panva panva marked this pull request as draft March 11, 2026 14:00
@panva
Copy link
Member Author

panva commented Mar 11, 2026

Too many WPT changes in flux at the moment. I'll rebase this once those land.

@panva panva marked this pull request as ready for review March 16, 2026 15:34
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 16, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 16, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 16, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/61875
✔  Done loading data for nodejs/node/pull/61875
----------------------------------- PR info ------------------------------------
Title      crypto: rename CShakeParams and KmacParams length to outputLength (#61875)
Author     Filip Skokan <panva.ip@gmail.com> (@panva)
Branch     panva:modern-updates -> nodejs:main
Labels     crypto, experimental, author ready, needs-ci, webcrypto, dont-land-on-v20.x, dont-land-on-v22.x, lts-watch-v24.x
Commits    1
 - crypto: rename CShakeParams and KmacParams length to outputLength
Committers 1
 - Filip Skokan <panva.ip@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/61875
Refs: https://github.com/web-platform-tests/wpt/pull/57802
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61875
Refs: https://github.com/web-platform-tests/wpt/pull/57802
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 18 Feb 2026 11:20:47 GMT
   ✔  Approvals: 1
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/61875#pullrequestreview-3956584601
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2026-03-16T19:19:24Z: https://ci.nodejs.org/job/node-test-pull-request/71824/
- Querying data for job/node-test-pull-request/71824/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/23165674676

panva added a commit that referenced this pull request Mar 16, 2026
@panva
Copy link
Member Author

panva commented Mar 16, 2026

Landed in ab8dc2b

@panva panva closed this Mar 16, 2026
@panva panva removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 16, 2026
@panva panva deleted the modern-updates branch March 16, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. experimental Issues and PRs related to experimental features. lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants