crypto: rename CShakeParams and KmacParams length to outputLength#61875
Closed
panva wants to merge 1 commit intonodejs:mainfrom
Closed
crypto: rename CShakeParams and KmacParams length to outputLength#61875panva wants to merge 1 commit intonodejs:mainfrom
panva wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
ca4ab2f to
95843e5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61875 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 676 676
Lines 206555 206555
Branches 39554 39552 -2
=======================================
+ Hits 185230 185237 +7
+ Misses 13461 13447 -14
- Partials 7864 7871 +7
🚀 New features to boost your workflow:
|
Member
Author
|
ping @nodejs/crypto |
Collaborator
Collaborator
anonrig
approved these changes
Mar 10, 2026
Member
Author
|
At this point we might as well wait for the WPT update web-platform-tests/wpt#57802 |
Member
Author
|
Too many WPT changes in flux at the moment. I'll rebase this once those land. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
anonrig
approved these changes
Mar 16, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61875 ✔ Done loading data for nodejs/node/pull/61875 ----------------------------------- PR info ------------------------------------ Title crypto: rename CShakeParams and KmacParams length to outputLength (#61875) Author Filip Skokan <panva.ip@gmail.com> (@panva) Branch panva:modern-updates -> nodejs:main Labels crypto, experimental, author ready, needs-ci, webcrypto, dont-land-on-v20.x, dont-land-on-v22.x, lts-watch-v24.x Commits 1 - crypto: rename CShakeParams and KmacParams length to outputLength Committers 1 - Filip Skokan <panva.ip@gmail.com> PR-URL: https://github.com/nodejs/node/pull/61875 Refs: https://github.com/web-platform-tests/wpt/pull/57802 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61875 Refs: https://github.com/web-platform-tests/wpt/pull/57802 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 18 Feb 2026 11:20:47 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/61875#pullrequestreview-3956584601 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2026-03-16T19:19:24Z: https://ci.nodejs.org/job/node-test-pull-request/71824/ - Querying data for job/node-test-pull-request/71824/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/23165674676 |
panva
added a commit
that referenced
this pull request
Mar 16, 2026
PR-URL: #61875 Refs: web-platform-tests/wpt#57802 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Member
Author
|
Landed in ab8dc2b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the implementation of
CShakeParamsandKmacParamsdictionaries with a change made in https://redirect.github.com/WICG/webcrypto-modern-algos/pull/52Documentation diff is due to keeping the attributes in a dictionary order.
Note that these are both experimentalIssues and PRs related to experimental features.
.
Refs: web-platform-tests/wpt#57802