Skip to content

n-api: refactor napi_addon_register_func#15088

Closed
boingoing wants to merge 1 commit intonodejs:masterfrom
boingoing:refactor_napi_addon_register_func
Closed

n-api: refactor napi_addon_register_func#15088
boingoing wants to merge 1 commit intonodejs:masterfrom
boingoing:refactor_napi_addon_register_func

Conversation

@boingoing
Copy link
Copy Markdown
Contributor

@boingoing boingoing commented Aug 30, 2017

As per discussion in abi-stable-node:
nodejs/abi-stable-node#256,
take a refactor to napi_addon_register_func such that
the result from the register function is assigned to
the module exports property. By making this change,
native module can be agnostic about which type of
module the environment supports.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. node-api Issues and PRs related to the Node-API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants