Skip to content

fix(git-node): simplify vulnerabilities.json creation, add missing EOL #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(git-node): simplify vulnerabilities.json creation, add missing EOL #1044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions lib/prepare_security.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,23 +203,19 @@ export default class PrepareSecurityRelease extends SecurityRelease {
}

async createVulnerabilitiesJSON(reports, dependencies, releaseDate) {
this.cli.separator('Creating vulnerabilities.json...');
const file = JSON.stringify({
this.cli.startSpinner('Creating vulnerabilities.json...');
const fileContent = JSON.stringify({
releaseDate,
reports,
dependencies
}, null, 2);
}, null, 2) + '\n';

const folderPath = path.join(process.cwd(), NEXT_SECURITY_RELEASE_FOLDER);
try {
fs.accessSync(folderPath);
} catch (error) {
fs.mkdirSync(folderPath, { recursive: true });
}
const folderPath = path.resolve(NEXT_SECURITY_RELEASE_FOLDER);
await fs.promises.mkdir(folderPath, { recursive: true });

const fullPath = path.join(folderPath, 'vulnerabilities.json');
fs.writeFileSync(fullPath, file);
this.cli.ok(`Created ${fullPath} `);
await fs.promises.writeFile(fullPath, fileContent);
this.cli.stopSpinner(`Created ${fullPath}`);

return fullPath;
}
Expand Down
Loading