Skip to content

fix: Apply FOV from previously-saved JSON files #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thibaulltt wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

fix: Apply FOV from previously-saved JSON files #389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7c6db3
fix(view): fetch fov from JSON files
Thibaulltt Mar 24, 2026
a4535be
fix: fly to the right FOV.
Thibaulltt Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/view.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,7 +1070,7 @@ void setViewFromJson(std::string jsonData, bool flyTo) {
// NOTE: it's important that we do this after the mode/dir settings, as this
// lets us do our flight
bool viewChanged = false;
if (j.find("fov") == j.end()) {
if (j.find("fov") != j.end()) {
newFov = j["fov"];
viewChanged = true;
}
Expand All @@ -1088,7 +1088,7 @@ void setViewFromJson(std::string jsonData, bool flyTo) {
}
if (viewChanged) {
if (flyTo) {
startFlightTo(newViewMat, fov);
startFlightTo(newViewMat, newFov);
} else {
setCameraViewMatrix(newViewMat);
fov = newFov;
Expand Down