Restore "explain" output when a dyndep file is loaded#2753
Open
bradking wants to merge 4 commits intoninja-build:masterfrom
Open
Restore "explain" output when a dyndep file is loaded#2753bradking wants to merge 4 commits intoninja-build:masterfrom
bradking wants to merge 4 commits intoninja-build:masterfrom
Conversation
Contributor
Author
Contributor
digit-google
left a comment
digit-google
left a comment
There was a problem hiding this comment.
Can you provide a reproduction case that better explains the issue, as well as a regression test for this?
bradking
force-pushed
the
explain-dyndep
branch
from
2fd920a to
731aead
Compare
bradking
changed the title
Contributor
Author
I opened #2758 to document the problematic case, and added a corresponding test to While working on this I also noticed #2759, but that behavior has been present since |
AJIOB
reviewed
Apr 1, 2026
AJIOB
reviewed
Apr 1, 2026
digit-google
reviewed
Apr 3, 2026
It makes more sense to live in the latter. Suggested-by: David 'Digit' Turner <digit+github@google.com>
This was regressed by commit 8e6c741 ("explain" debug prints just before each command is run, 2022-01-06, v1.13.0~1^2~56^2~2). Add a test demonstrating the problems, called out by FIXME comments. Issue: ninja-build#2758, ninja-build#2759
Since commit 8e6c741 ("explain" debug prints just before each command is run, 2022-01-06, v1.13.0~1^2~56^2~2) the "loading dyndep file '...'" explanation has not been printed. Instead the explanation has been recorded for the dyndep file's node *after* it has been brought up-to-date, and therefore never printed. This explanation is generated just before its operation runs, so we can print it immediately instead of buffering it. Fixes: ninja-build#2758
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #2067 the "loading dyndep file '...'" explanation has not been printed. Instead the explanation has been recorded for the dyndep file's node after it has been brought up-to-date, and therefore never printed.
This explanation is generated just before its operation runs, so we can print it immediately instead of buffering it.
Fixes: #2758