MissingDeps tests do not cover depfile‑based dependency loading#2742
Open
moritzx22 wants to merge 2 commits intoninja-build:masterfrom
Open
MissingDeps tests do not cover depfile‑based dependency loading#2742moritzx22 wants to merge 2 commits intoninja-build:masterfrom
moritzx22 wants to merge 2 commits intoninja-build:masterfrom
Conversation
…ncy loading Adds unit tests that trigger the depfile‑loading path in the missingdeps logic. The new tests close the coverage gap around the dep‑loading algorithm in 'NodeStoringImplicitDepLoader'.
moritzx22
force-pushed
the
missingDepsTestCoverage
branch
from
364c7c6 to
3eb8988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current unit tests for missingdeps do not cover the code path that handles implicit dependencies loaded from depfiles. In particular, the logic inside
NodeStoringImplicitDepLoader(see lines 30–48 in missing_deps.cc) is never exercised because none of the existing tests create or load an actual depfile.This PR adds new unit tests that generate a real depfile and trigger the depfile‑based dependency loading path.
These additions close the coverage gap and ensure that future changes to depfile handling or missing‑deps logic are properly validated.