Fix unit test crash, if test fails#2684
Merged
jhasse merged 1 commit intoninja-build:masterfrom Nov 29, 2025
Merged
Conversation
mathstuf
approved these changes
Oct 21, 2025
Collaborator
|
Can you change the commit message to "Fix unit test crash, if test fails"? It isn't really about a memory leak if I understand it correctly. |
moritzx22
force-pushed
the
testSuiteMemoryLeak
branch
2 times, most recently
from
6c03de1 to
90e0a41
Compare
Contributor
Author
Done
|
moritzx22
force-pushed
the
testSuiteMemoryLeak
branch
from
90e0a41 to
c9de7ce
Compare
moritzx22
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unit test crash, if test fails.
Note: This is coming from PR 2680, but the issue is not strictly related to PR2680