Open
Conversation
Update CI
dlesnoff
reviewed
Dec 4, 2023
| fail-fast: false | ||
| matrix: | ||
| nim-version: | ||
| - '1.4.8' |
Contributor
There was a problem hiding this comment.
We might want to drop support for 1.4.8.
Contributor
Author
Member
There was a problem hiding this comment.
+1 for dropping 1.4.x
It can also be part of a separate PR if you will. Don't forget to also bump minimal supported version in the .nimble file.
dlesnoff
reviewed
Dec 4, 2023
dlesnoff
reviewed
Dec 4, 2023
Comment on lines
+40
to
+42
| let hi64 = r.rand(hi64Max) | ||
| limbs.add(uint32(hi64 and uint32.high)) | ||
| limbs.add(uint32(hi64 shr 32)) |
Contributor
There was a problem hiding this comment.
This works by generating a 64-bit number. I am surprised that this works well on a 32-bit architecture.
Contributor
Author
There was a problem hiding this comment.
Why wouldn't it? 32 bit architectures support 64 bit numbers perfectly well, they're just slower (because they take up two memory locations).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test on i386 (a 32 bit arch) in the CI and update the versions tested.
Closes #48.
The CI job uses the prebuilt binaries from https://nim-lang.org/install.html (since most actions aren't available in a container). This means we can finally confirm that the library works on 32 bit architectures. I had to fix an example and the
randcode (to work around nim-lang/Nim#16360). I also added a test forr.rand(x..x).