Skip to content

Switch from pyright to basedpyright #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikobockerman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Switch from pyright to basedpyright #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
103d86d
Switch from pyright to basedpyright
nikobockerman Mar 3, 2026
c58dc07
Enable recommended mode for basedpyright
nikobockerman Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci-python-project.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ jobs:
directory: ${{ inputs.directory }}
task: check:mypy

check-pyright:
check-basedpyright:
if: always() && contains(fromJSON('["skipped", "success"]'), needs.uv-cache.result)
needs: uv-cache
uses: ./.github/workflows/mise-uv-task.yaml
with:
directory: ${{ inputs.directory }}
task: check:pyright
task: check:basedpyright

run-all:
if: inputs.directory != 'aoc-main'
Expand All @@ -65,7 +65,7 @@ jobs:
if: always()
needs:
- check-mypy
- check-pyright
- check-basedpyright
- run-all
- test-pytest
runs-on: ubuntu-24.04
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ jobs:
directory: .
task: check:prettier

check-pyright-repo:
check-basedpyright-repo:
needs: mise-cache-ubuntu
uses: ./.github/workflows/mise-task.yaml
with:
directory: .
task: check:pyright-repo
task: check:basedpyright-repo

check-ruff:
needs: mise-cache-ubuntu
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
if: always()
needs:
- check-prettier
- check-pyright-repo
- check-basedpyright-repo
- check-ruff
- check-ruff-format
- check-shellcheck
Expand Down
6 changes: 3 additions & 3 deletions aoc-main/mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[tasks.check]
depends = [
"check:mypy",
"check:pyright",
"check:basedpyright",
"check:pytest",
]

Expand All @@ -16,8 +16,8 @@ pythonVersion=$(cat pyproject.toml | yq -p toml '.project.requires-python' | sed
mypy --python-executable "${pythonExecutable}" --python-version "${pythonVersion}" .
"""

[tasks."check:pyright"]
run = "uv run pyright"
[tasks."check:basedpyright"]
run = "uv run basedpyright"

[tasks."check:pytest"]
run = "uv run pytest"
Expand Down
2 changes: 1 addition & 1 deletion aoc-main/pyrightconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"include": ["**"],
"typeCheckingMode": "strict"
"typeCheckingMode": "recommended"
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to switching to basedpyright, this relaxes typeCheckingMode from strict to recommended. If the goal is purely switching the checker binary, consider leaving this as strict; otherwise please document the intentional reduction in strictness in the PR description/title because it affects what failures CI will report.

Copilot uses AI. Check for mistakes.
}
8 changes: 4 additions & 4 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ python = "3.14.3"
uv = "0.10.7"

# Common tools
"npm:pyright" = "1.1.408"
"npm:basedpyright" = "1.38.2"
"pipx:shellcheck-gha" = "0.1.2"
prettier = "3.6.2"
ruff = "0.15.4"
Expand Down Expand Up @@ -69,7 +69,7 @@ shell = "sh -c"
[tasks.check]
depends = [
"check:prettier",
"check:pyright-repo",
"check:basedpyright-repo",
"check:ruff",
"check:ruff:format",
"check:shellcheck",
Expand Down Expand Up @@ -100,8 +100,8 @@ fi
prettier --ignore-path=.gitignore --ignore-path=.prettierignore "$userIgnoreArg" --check .
"""

[tasks."check:pyright-repo"]
run = "pyright"
[tasks."check:basedpyright-repo"]
run = "basedpyright"

[tasks."check:ruff"]
run = "ruff check"
Expand Down
2 changes: 1 addition & 1 deletion pyrightconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"include": ["**"],
"exclude": ["aoc-main/", "solvers/cpp/cmake-conan/", "solvers/python/"],
"typeCheckingMode": "strict"
"typeCheckingMode": "recommended"
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes typeCheckingMode from strict to recommended in addition to swapping to basedpyright. If the PR is only intended to switch tooling, consider keeping strict; if loosening is intended, please call it out explicitly since it changes the CI contract for the repo root type-check.

Copilot uses AI. Check for mistakes.
}
6 changes: 3 additions & 3 deletions solvers/python/mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[tasks.check]
depends = [
"check:mypy",
"check:pyright",
"check:basedpyright",
"check:pytest",
]

Expand All @@ -16,8 +16,8 @@ pythonVersion=$(cat pyproject.toml | yq -p toml '.project.requires-python' | sed
mypy --python-executable "${pythonExecutable}" --python-version "${pythonVersion}" .
"""

[tasks."check:pyright"]
run = "uv run pyright"
[tasks."check:basedpyright"]
run = "uv run basedpyright"

[tasks."check:pytest"]
run = "uv run pytest"
Expand Down
2 changes: 1 addition & 1 deletion solvers/python/pyrightconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"include": ["**"],
"typeCheckingMode": "strict"
"typeCheckingMode": "recommended"
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title indicates switching the type checker (pyright -> basedpyright), but this also relaxes the config from strict to recommended. If the intent is only the tool switch, keep typeCheckingMode as strict; otherwise please update the PR description/title to explicitly call out the change in type-checking strictness (it can materially change what CI catches).

Copilot uses AI. Check for mistakes.
}
Loading