Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARIA/DOM contract changed from per-row progressbars to a single progressbar container.
Before, each skeleton row had role and ARIA attributes; now ARIA is on wrapper or host and rows are aria-hidden in skeleton.tsx:205.
This can break consumers/tests querying multiple progressbars (for example selectors like nb-skeleton >>> [role="progressbar"] expecting count items).
Keyboard focus behavior changed.
tabindex="0" was removed from row elements (same area in skeleton.tsx:205).
If anyone relied on focusability for testing or interaction, that is a behavioral break.
Internal shadow structure changed.
Default render now uses a wrapper element (or host in asChild mode) around rows in skeleton.tsx:222.
Shadow DOM selectors targeting previous direct children can break.