Skip to content

github: Fix outdated aspects of Comment-on-PR.yml and Notify-Convention-Change.yml #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mshafer-NI merged 5 commits into from
Mar 17, 2026
Merged

github: Fix outdated aspects of Comment-on-PR.yml and Notify-Convention-Change.yml #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d57923d
github: Remove with: GITHUB_TOKEN from thollander/actions-comment-pul…
bkeryan Mar 17, 2026
1b72502
github: Pin actions/checkout
bkeryan Mar 17, 2026
ed12da0
github: Specify required permissions for jobs that call thollander/ac…
bkeryan Mar 17, 2026
577a4b0
github: Add a name for Comment-on-PR.yml
bkeryan Mar 17, 2026
438006a
github: Remove actions/checkout from comment workflows
bkeryan Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/Comment-on-PR.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
name: Comment on PR

on:
pull_request_target:
paths-ignore:
Expand All @@ -10,13 +12,11 @@ jobs:
comment_on_pr:
runs-on: ubuntu-latest
name: PR comment
permissions:
pull-requests: write
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Comment on PR
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
message: |
Thank you for contributing! :wave:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4 changes: 2 additions & 2 deletions .github/workflows/Notify-Convention-Change.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ jobs:
notify:
runs-on: ubuntu-latest
needs: org-check
permissions:
pull-requests: write
steps:
- uses: actions/checkout@main
- name: Comment on PR
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
Expand All @@ -43,4 +44,3 @@ jobs:
@Adithyak1998
@innagarc
@ShibaniRout
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading