Open
Conversation
Owner
|
Hi, sorry for the late reply I was travelling. Changes looks good. For jcmdline I don't really like it but that's what the original project used and changing it was too much work. Too bad v2.0.0 is still not available on Maven... Happy to merge if you could address some minor things:
Markdown would be good yeah, presumably that can be achieved mostly with another set of templates? Cheers, Nico |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Nico,
What are your thoughts about the following updates?
The main reason I was thinking about this change so that markdown files can be generated for documentation, which works well with putting docs on github.
NOTE: I didn't update to newest jcmdline for any specific reason.