This repository was archived by the owner on Sep 25, 2025. It is now read-only.
Conversation
…ning for future behavior change
…ted from 'draft' status
2 tasks
* Added Brendan's tests - passing with warnings * Applied Brendan's fix - fixes warnings, but breaks in default-argument case * fix default issue + some cleanup
Resolves issue with play_by_play data having incorrect old_game_id values. For example, all old_game_id values in the play_by_play_2023 for week 15 start with "2022" but they begin with "2023" in the pbp_participation_2023 data.
* Add roster tests for multiple seasons * fix roster import indices
…ilable (#107) * Exclude pbp participation data if the file isn't available * Fixed incorrect error import
* add ability to import def pfr data * add missing quotation mark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nfl_data_py 0.3.3 fixes the test suite and resolves all submitted issues that were easy to fix while still supporting all the way back to Python 3.6 and associated dependencies. This is intended to be the final, stable v0 release before the impending upgrade to nfl_data_py 1.0.0, though bug and security patches may still be submitted in the future.