feat: show genome coverage outline behind "too many markers" message#1760
Merged
ivan-aksamentov merged 2 commits intomasterfrom Mar 10, 2026
Merged
feat: show genome coverage outline behind "too many markers" message#1760ivan-aksamentov merged 2 commits intomasterfrom
ivan-aksamentov merged 2 commits intomasterfrom
Conversation
…sage When the marker count exceeds the threshold, draw unsequenced region bars behind the error text instead of showing only the message. Reuses the same `SequenceMarkerUnsequencedStart`/`End` components as the normal view for consistent appearance and tooltips. Closes #1759 
There was a problem hiding this comment.
Pull request overview
Adds a coverage “outline” behind the “too many markers” fallback so users still get visual genome coverage context when marker rendering is capped.
Changes:
- Render unsequenced start/end markers behind the threshold warning in absolute + relative sequence views
- Add layered wrapper/text styled components to overlay the warning while keeping SVG tooltips interactive
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/nextclade-web/src/components/SequenceView/SequenceViewStyles.tsx | Adds wrapper + overlay text styled components for layering SVG + message |
| packages/nextclade-web/src/components/SequenceView/SequenceViewRelative.tsx | Uses wrapper/text + draws unsequenced markers in “too many markers” fallback |
| packages/nextclade-web/src/components/SequenceView/SequenceViewAbsolute.tsx | Same as relative view for absolute coordinate rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/nextclade-web/src/components/SequenceView/SequenceViewRelative.tsx
Show resolved
Hide resolved
packages/nextclade-web/src/components/SequenceView/SequenceViewAbsolute.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the marker count exceeds the display threshold, the sequence view previously showed only a text message with no visual context. Now, unsequenced region bars are drawn behind the text, so users can still see genome coverage at a glance. The bars reuse the existing
SequenceMarkerUnsequencedStart/Endcomponents for consistent appearance, positioning, and tooltips.pointer-events: noneso unsequenced bar tooltips remain interactiveSequenceViewCoverageWrapperandSequenceViewCoverageTextstyled components for the layered layoutResolves: #1759