🪪 Add further profile items including enablement switch#5936
Open
AndyScherzinger wants to merge 2 commits intomasterfrom
Open
🪪 Add further profile items including enablement switch#5936AndyScherzinger wants to merge 2 commits intomasterfrom
AndyScherzinger wants to merge 2 commits intomasterfrom
Conversation
AndyScherzinger
added
design
AndyScherzinger
force-pushed
the
feat/noid/profileFields
branch
2 times, most recently
from
a9ee2cd to
fe7ae84
Compare
AndyScherzinger
added
3. to review
AndyScherzinger
requested review from
jancborchardt,
mahibi,
nimishavijay and
sowjanyakch
AndyScherzinger
changed the title
AndyScherzinger
force-pushed
the
feat/noid/profileFields
branch
from
fe7ae84 to
a4751a4
Compare
jancborchardt
previously requested changes
Mar 8, 2026
AndyScherzinger
force-pushed
the
feat/noid/profileFields
branch
2 times, most recently
from
44135e0 to
8bf7bb9
Compare
AndyScherzinger
force-pushed
the
feat/noid/profileFields
branch
from
8bf7bb9 to
6eec609
Compare
mahibi
previously requested changes
Mar 8, 2026
app/src/main/java/com/nextcloud/talk/profile/ProfileActivity.kt
Outdated
Show resolved
Hide resolved
AndyScherzinger
force-pushed
the
feat/noid/profileFields
branch
2 times, most recently
from
e8cf958 to
18f9986
Compare
Member
Author
|
@mahibi fixed your comments and also added edit state preservation upon screen rotation (also not implemented before but now we have it) |
sowjanyakch
approved these changes
Mar 9, 2026
AndyScherzinger
force-pushed
the
feat/noid/profileFields
branch
from
18f9986 to
7d03a92
Compare
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
feat/noid/profileFields
branch
from
7d03a92 to
c422e56
Compare
AndyScherzinger
dismissed
mahibi’s stale review
Review feedback has been implemented
AndyScherzinger
force-pushed
the
feat/noid/profileFields
branch
from
c422e56 to
f77922f
Compare
…he grown number of items ...and ensure device rotation preserves the editing/red-only state and removed unneeded lifecycle mgmt Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
feat/noid/profileFields
branch
from
f77922f to
580f830
Compare
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5936.apk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mixed language is due to the lack of translations, which would happen after the merge via transifex.
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x