Only mask the permissions for the users home directory for public shares#59511
Only mask the permissions for the users home directory for public shares#59511CarlSchwan merged 2 commits intomasterfrom
Conversation
icewind1991
requested review from
ArtificialOwl,
CarlSchwan,
leftybournes and
salmart-dev
and removed request for
a team
icewind1991
force-pushed
the
public-share-only-mask-home
branch
2 times, most recently
from
4cf7e05 to
3a73754
Compare
|
/backport to stable-32.0 |
|
Backporting to stable 32 should be enough for what we need. |
cristianscheid
left a comment
cristianscheid
left a comment
There was a problem hiding this comment.
Looks good to me.
Signed-off-by: Robin Appelman <robin@icewind.nl>
…c shares this ensures that versions/trashbin/etc is still usable Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
public-share-only-mask-home
branch
from
3a73754 to
3cd3c6d
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable-32.0
git pull origin stable-32.0
# Create the new backport branch
git checkout -b backport/59511/stable-32.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e96a89e6 3cd3c6dd
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/59511/stable-32.0Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/59511/stable-32.0') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable33 |
|
/backport to stable32 |
| * @var int the permissions bits we want to keep | ||
| */ | ||
| private $mask; | ||
| protected readonly int $mask; |
There was a problem hiding this comment.
PHP Fatal error: Cannot redeclare readonly property OC\Files\Storage\Wrapper\PermissionsMask::$mask as non-readonly OCA\Guests\Storage\DirMask::$mask in …/apps/guests/lib/Storage/DirMask.php on line 22
Breaks the guests app again
5 participants
this ensures that versions/trashbin/etc is still usable.
DirPermissionsMaskis copied from the guests appFixes #59354