fix(invite): Add logging and fix decryption key in InviteService#1507
Open
fix(invite): Add logging and fix decryption key in InviteService#1507
Conversation
sendInvite() will silently return false with no logging when the lostpassword token is missing. Added warning/error logs and fixed decryption key to use getEMailAddress() matching GuestManager encryption. Aslo removed dead code in Hooks.php. Signed-off-by: nfebe <fenn25.fn@gmail.com>
|
|
||
|
|
||
| $user = $this->userSession->getUser(); | ||
| $this->userManager->get($shareWith); |
Member
There was a problem hiding this comment.
Maybe this was supposed to catch some issues? Better to keep it and check if it's null to throw an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendInvite() will silently return false with no logging when the lostpassword token is missing. Added warning/error logs and fixed decryption key to use getEMailAddress() matching GuestManager encryption.
Aslo removed dead code in Hooks.php.