fix: select and focus search input fields on Ctrl-F#2365
Merged
Conversation
- First Ctrl-F: select + focus page filter - Second Ctrl-F: open unified search - Third Ctrl-F: open browser search util Fixes: #2317 Signed-off-by: Jonas <jonas@freesources.org>
If member search is not focussed: - First Ctrl-F: select + focus member search - Second Ctrl-F: open unified search - Third Ctrl-F: open browser search util If member search is already focussed: - First Ctrl-F: open unified search - Second Ctrl-F: open browser search util Fixes: #2303 Signed-off-by: Jonas <jonas@freesources.org>
max-nextcloud
approved these changes
Mar 24, 2026
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
I was confused by the stack at first. I was expecting the handler to go through the stack until one item handles the event. But now I see that the stack is just for keeping the other handlers around for the time when the topmost element on the stack has been popped.
Playwright seems to be unhappy in the NavigationSection still.
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/search_ctrl_f_shortcut
branch
from
cf83923 to
62b7ff2
Compare
Member
Author
Good catch, fixed now by first hovering over the three-dot-menu before clicking it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
fix(PageList): select and focus filter on Ctrl-F
Fixes: #2317
fix(MemberPicker): Focus member search on Ctrl-F
If member search is not focussed:
If member search is already focussed:
Fixes: Members overview and global search stealing each others focus #2303
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)