Open
Conversation
The notFound watcher should be redundant nowadays. We already use the `fileId` query param to determine `currentPageId`, so the situation that `currentPage` is undefined but query param `fileId` is defined should not exist. Signed-off-by: Jonas <jonas@freesources.org>
Move the business logic to `currentPageId()`. No need to get full page just for returning the id. Don't use `state.pageById()`, which is a function and therefore cannot be cached. Using `state.pages.find()` instead should help with performance. Signed-off-by: Jonas <jonas@freesources.org>
More places to use cacheable computed properties that don't depend on non-cachable function `pageById()`. Signed-off-by: Jonas <jonas@freesources.org>
We sometimes use `current<getter>` for the current collectie and `<getter>` for a collective-agnostic getter and sometimes `<getter>` for the current collective vs. `<getter>ForCollective` for a collective- agnostic getter. Let's try to harmonize this and always use `current<getter>` vs. `<getter>`. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
`sortedSubpagesByParentId()` gets calculated once and stays cached until either `state.pages` or `state.sortOrder` changes. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
…yPagentId Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
max-nextcloud
force-pushed
the
perf/frontend
branch
from
e3ed849 to
e42b665
Compare
Collaborator
Author
|
Some things seem to be broken:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pageById()