Open
Conversation
Contributor
|
step1에 inject 기능이 미리 구현되어 있진 않을텐데... java-jdbc에 구현된 코드를 적용하셨다는 말씀이실까요? |
kang-hyungu
requested changes
Nov 18, 2024
Contributor
kang-hyungu
left a comment
kang-hyungu
left a comment
There was a problem hiding this comment.
안녕하세요 현오님
리뷰 내용은 pr 코멘트로 남겨두었습니다.
수정하시고 리뷰 재요청주세요~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
step1에서 recursive하게 inject하는 부분이 구현되어있어서 step1의 피드백을 적용해서 step2 pr을 열었는데요,
혹시 추가적으로 피드백 주실부분있으면 주시면감사하겠습니다~