Merged
Conversation
Add missing .nvmrc (Node 22) required by the reusable node-audit workflow and fix npm audit findings: - lodash <=4.17.23: Code Injection via _.template (GHSA-r5fr-rjxr-66jc) and Prototype Pollution via _.unset/_.omit (GHSA-f23m-r3pf-42rh) - path-to-regexp <0.1.13: ReDoS via multiple route params (GHSA-37ch-88jc-xwx2) - ajv <6.14.0: ReDoS when using $data option (GHSA-2g4f-4pwh-qvx6)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Node.js version to 22 and increments several dependency versions in package-lock.json, including ajv, lodash, and path-to-regexp. Feedback was provided regarding the unintended change of the package name to 'fix-timetracker-audit' in the lock file, which should be reverted to maintain consistency.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=========================================
Coverage 81.49% 81.49%
Complexity 2579 2579
=========================================
Files 172 172
Lines 7107 7107
=========================================
Hits 5792 5792
Misses 1315 1315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
CybotTM
added a commit
that referenced
this pull request
Apr 3, 2026
## Summary - Fix `package-lock.json` name from `fix-timetracker-audit` (branch name) to `timetracker` - Caused by `npm audit fix` using the working directory name as package name - Addresses review comments on PR #274 ## Test plan - [ ] Verify package-lock.json has correct name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrcfile (Node 22) required by the reusablenode-audit.ymlworkflow, which defaultsnode-version-fileto.nvmrcnpm audit fix:_.template(GHSA-r5fr-rjxr-66jc) and Prototype Pollution via_.unset/_.omit(GHSA-f23m-r3pf-42rh)$dataoption (GHSA-2g4f-4pwh-qvx6)Root cause
The Security workflow calls
netresearch/.github/.github/workflows/node-audit.ymlwhich defaultsnode-version-fileto.nvmrc. Since the repo had no.nvmrc,actions/setup-nodefailed before npm audit ever ran. Even if setup-node had succeeded, the audit would have failed on the lodash and path-to-regexp high-severity findings.Test plan
.nvmrcfound,npm auditclean)