[self-hosted] Add selfhosted scaling note#5769
Conversation
Entire-Checkpoint: 7d03435efeeb
📝 WalkthroughWalkthroughThe changes modify the Traefik post-setup instruction output in the getting-started script by reorganizing conditional formatting for the WireGuard port section, adding new guidance text for homelabs and smaller organizations, and including recommendations for commercial on-premise licensing and scaling guidance. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
infrastructure_files/getting-started.sh (1)
1155-1175:⚠️ Potential issue | 🟠 MajorFix broken documentation URL before merging.
The scaling guide URL is returning a 404 error:
https://docs.netbird.io/scaling-your-self-hosted-deployment→ HTTP 404 Not FoundThe code directs users to this non-existent page, which breaks the intended guidance flow. Verify the correct documentation path and update the URL to point to the actual scaling guide. The commercial license URL (
https://netbird.io/pricing) is reachable and valid.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@infrastructure_files/getting-started.sh` around lines 1155 - 1175, The scaling guide URL string echo " Scaling guide: https://docs.netbird.io/scaling-your-self-hosted-deployment" is pointing to a 404; locate that echo in the script (near the block that prints deployment guidance alongside the commercial license echo) and replace the broken URL with the correct docs path after verifying the actual scaling/self-hosting guide URL on docs.netbird.io, keeping the same echo formatting; ensure any other occurrences of the old URL are updated and run a quick curl/check to confirm the new URL returns 200.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@infrastructure_files/getting-started.sh`:
- Around line 1155-1175: The scaling guide URL string echo " Scaling guide:
https://docs.netbird.io/scaling-your-self-hosted-deployment" is pointing to a
404; locate that echo in the script (near the block that prints deployment
guidance alongside the commercial license echo) and replace the broken URL with
the correct docs path after verifying the actual scaling/self-hosting guide URL
on docs.netbird.io, keeping the same echo formatting; ensure any other
occurrences of the old URL are updated and run a quick curl/check to confirm the
new URL returns 200.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 83d517a9-c2dd-4db8-a2ea-5c566d6808e8
📒 Files selected for processing (1)
infrastructure_files/getting-started.sh
braginini
changed the title
braginini
changed the title
3 participants
Entire-Checkpoint: 7d03435efeeb
Describe your changes
Issue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
Add redirect to scaling selfhosted docs#678
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__
Summary by CodeRabbit