Conversation
Contributor
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bcmmbaga
previously approved these changes
Mar 24, 2026
Resolve OpenAPI spec conflict by keeping both FleetDM schemas and new IntegrationSyncFilters/IntegrationEnabled schemas. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
shared/management/http/api/openapi.yml (1)
4286-4288: Constrainapi_urlas a URI in the contract.Right now any arbitrary string satisfies the schema, so generated clients and docs will not catch malformed Fleet URLs before the request hits the server.
Proposed schema tweak
api_url: type: string + format: uri description: FleetDM server URLapi_url: type: string + format: uri description: FleetDM server URLAlso applies to: 4338-4340
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@shared/management/http/api/openapi.yml` around lines 4286 - 4288, The api_url property in the OpenAPI contract currently allows any string; update its schema to require a URI by adding format: uri (or format: uri-reference if relative URIs are allowed) and optionally a pattern or example to clarify expected values; apply this change to the api_url definitions at both locations (the one around api_url and the other occurrence referenced in the comment) so generated clients and docs will validate FleetDM server URLs as URIs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@shared/management/http/api/openapi.yml`:
- Around line 10852-10883: The OpenAPI docs for the singleton route
/api/integrations/edr/fleetdm contain incorrect references to an "integration
ID" (e.g., in the 400 and 404 response descriptions); update the descriptions
under the GET/PUT/DELETE responses for this path so they do not mention an ID or
"the given ID" and instead describe errors in terms appropriate for a singleton
resource (e.g., "Bad Request (e.g., invalid request format)" and "Not Found
(integration does not exist)"), and apply the same wording cleanup to the
equivalent blocks referenced (the other occurrences around lines 10904-10920 and
10931-10958).
---
Nitpick comments:
In `@shared/management/http/api/openapi.yml`:
- Around line 4286-4288: The api_url property in the OpenAPI contract currently
allows any string; update its schema to require a URI by adding format: uri (or
format: uri-reference if relative URIs are allowed) and optionally a pattern or
example to clarify expected values; apply this change to the api_url definitions
at both locations (the one around api_url and the other occurrence referenced in
the comment) so generated clients and docs will validate FleetDM server URLs as
URIs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d7514f1a-1df7-40ba-8557-52463abd3ce4
📒 Files selected for processing (3)
shared/management/client/rest/edr.goshared/management/http/api/openapi.ymlshared/management/http/api/types.gen.go
Comment on lines
+10852
to
+10883
| description: Retrieves a specific EDR FleetDM integration by its ID. | ||
| responses: | ||
| '200': | ||
| description: Successfully retrieved the integration details. | ||
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/EDRFleetDMResponse' | ||
| '400': | ||
| description: Bad Request (e.g., invalid integration ID format). | ||
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/ErrorResponse' | ||
| '401': | ||
| description: Unauthorized. | ||
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/ErrorResponse' | ||
| '404': | ||
| description: Not Found (e.g., integration with the given ID does not exist). | ||
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/ErrorResponse' | ||
| '500': | ||
| description: Internal Server Error. | ||
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/ErrorResponse' |
Contributor
There was a problem hiding this comment.
Drop the nonexistent “integration ID” wording from this singleton route.
/api/integrations/edr/fleetdm has no {id} parameter, but the GET/PUT/DELETE docs still talk about invalid IDs and “the given ID”. That makes the contract self-contradictory for SDK consumers.
Suggested wording cleanup
get:
tags:
- EDR FleetDM Integrations
summary: Get EDR FleetDM Integration
- description: Retrieves a specific EDR FleetDM integration by its ID.
+ description: Retrieves the FleetDM EDR integration configured for the authenticated account.
@@
- '400':
- description: Bad Request (e.g., invalid integration ID format).
+ '400':
+ description: Bad Request.
@@
- '404':
- description: Not Found (e.g., integration with the given ID does not exist).
+ '404':
+ description: Not Found (e.g., no FleetDM integration is configured for the authenticated account).
@@
delete:
tags:
- EDR FleetDM Integrations
summary: Delete EDR FleetDM Integration
- description: Deletes an EDR FleetDM Integration by its ID.
+ description: Deletes the FleetDM EDR integration configured for the authenticated account.Also applies to: 10904-10920, 10931-10958
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@shared/management/http/api/openapi.yml` around lines 10852 - 10883, The
OpenAPI docs for the singleton route /api/integrations/edr/fleetdm contain
incorrect references to an "integration ID" (e.g., in the 400 and 404 response
descriptions); update the descriptions under the GET/PUT/DELETE responses for
this path so they do not mention an ID or "the given ID" and instead describe
errors in terms appropriate for a singleton resource (e.g., "Bad Request (e.g.,
invalid request format)" and "Not Found (integration does not exist)"), and
apply the same wording cleanup to the equivalent blocks referenced (the other
occurrences around lines 10904-10920 and 10931-10958).
bcmmbaga
approved these changes
Mar 31, 2026
mlsmaycon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
netbirdio/docs#673
Summary by CodeRabbit
New Features