Preliminary BurgerGov for governance token by Hecate2 · Pull Request #3 · neoburger/code

Hecate2 · 2021-11-04T01:57:40Z

No description provided.

BurgerGov.cs

vang1ong7ang · 2021-11-04T04:10:05Z

BurgerGov.cs

+        // DO NOT USE the prefix 0x14, because this is the key prefix for NEP-17 token account balance
+        [InitialValue("Nb2CHYY5wTh2ac58mTue5S3wpG6bQv5hSY", ContractParameterType.Hash160)]
+        private static readonly UInt160 DEFAULT_OWNER = default;
+        private static readonly byte PREFIX_OWNER = 0xff;


then PREFIX_OWNER is not necessary

vang1ong7ang · 2021-11-04T04:13:52Z

BurgerGov.cs

+    [ManifestExtra("Description", "NeoBurger Governance Token")]
+    [SupportedStandards("NEP-17")]
+    [ContractPermission("*", "*")]
+    public class BurgerGov : Nep17Token


the name can be NeoBurgerGovernanceToken and the filename can be NeoBurgerGovernanceToken.cs

vang1ong7ang · 2021-11-04T04:14:35Z

BurgerGov.cs

+        private static readonly byte PREFIX_VOTE = 0xc1;
+
+        public override byte Decimals() => 8;
+        public override string Symbol() => "bNEOg";


the symbol can be NOBUG ("NEOBURGER".remove("er"))

vang1ong7ang · 2021-11-04T04:15:01Z

BurgerGov.cs

+
+        public override byte Decimals() => 8;
+        public override string Symbol() => "bNEOg";
+        public static UInt160 Owner() => (UInt160)Storage.Get(Storage.CurrentContext, new byte[] { PREFIX_OWNER });


then Owner is not necessary

vang1ong7ang · 2021-11-04T04:16:05Z

BurgerGov.cs

+
+        public static void _deploy(object data, bool update)
+        {
+            if (!update)


no need to add if (!update) imo

vang1ong7ang · 2021-11-04T04:16:46Z

BurgerGov.cs

+
+        public static void Update(ByteString nefFile, string manifest)
+        {
+            ExecutionEngine.Assert(Runtime.CheckWitness(Owner()));


check witness of the dao itself

vang1ong7ang · 2021-11-04T04:17:16Z

BurgerGov.cs

+
+        public static void OnNEP17Payment(UInt160 from, BigInteger amount, object data)
+        {
+            throw new System.Exception("Not implemented for now");


remove this line to accept airdrop

vang1ong7ang · 2021-11-04T04:20:15Z

readonly method can be placed above like below in BurgerNEO.cs

public static UInt160 Strategist() => (UInt160)Storage.Get(Storage.CurrentContext, new byte[] { PREFIXSTRATEGIST });

Hecate2 · 2021-11-04T04:32:48Z

Then we need another method in BurgerNeoGovernanceToken to check the voting result of proposals and execute the proposal?
Otherwise nobody can call the methods in BurgerNeoGovernanceToken

remove `if (!update)`; allow NEP17Payment; on-line readonly methods

vang1ong7ang · 2021-11-04T04:55:40Z

Then we need another method in BurgerNeoGovernanceToken to check the voting result of proposals and execute the proposal

i think so

vang1ong7ang · 2021-11-04T04:56:43Z

NeoBurgerGovernanceToken.cs

+    [ContractPermission("*", "*")]
+    public class NeoBurgerGovernanceToken : Nep17Token
+    {
+        // DO NOT USE the prefix 0x14, because this is the key prefix for NEP-17 token account balance


imo all the comments can be removed

NeoBurgerGovernanceToken.cs

…ult delegate.

Hecate2 · 2021-11-05T03:08:22Z

The method CountVote has been preliminarily tested, where the iterator works well. ExecuteProposal can reuse CountVote, but may cost more GAS.

…ValidDelegate`

…ed || I have invalid delegate but default delegate voted

Hecate2 · 2021-11-05T05:50:45Z

Ready for further complete tests

Hecate2 · 2021-11-08T07:44:56Z

Stored proposal attributes as structs in commit f17807c. Unit-tested.

vang1ong7ang · 2021-11-08T12:48:26Z

NeoBurgerGovernanceToken.cs

+        private static readonly byte PREFIX_DEFAULT_DELEGATE = 0x82;
+        private static readonly byte PREFIX_DELEGATE_THRESHOLD = 0x83;
+        private static readonly byte PREFIX_VOTE = 0xc1;
+        private static readonly byte PREFIX_VOTING_PERIOD = 0xc2;


we can mark this one constant and upgrade the contract if needed

Hecate2 force-pushed the BurgerGov branch from b8c4c06 to ef5644a Compare November 4, 2021 02:09

Preliminary BurgerGov for governance token

b9a89fa

Hecate2 force-pushed the BurgerGov branch from ef5644a to b9a89fa Compare November 4, 2021 02:18

Hecate2 and others added 2 commits November 4, 2021 11:59

throw "The proposal does not exist" when voting_deadline == 0

a1a155c

Update BurgerGov.cs

138228a

vang1ong7ang reviewed Nov 4, 2021

View reviewed changes

BurgerGov.cs Outdated Show resolved Hide resolved

vang1ong7ang reviewed Nov 4, 2021

View reviewed changes

Hecate2 added 2 commits November 4, 2021 12:45

Change filename, class name and token symbol; remove owner;

de82d6a

remove `if (!update)`; allow NEP17Payment; on-line readonly methods

Merge branch 'BurgerGov' of github.com:Hecate2/code into BurgerGov

023ca02

vang1ong7ang reviewed Nov 4, 2021

View reviewed changes

NeoBurgerGovernanceToken.cs Show resolved Hide resolved

Hecate2 added 6 commits November 4, 2021 14:49

remove comments

5102dd8

NOT PRODUCTION READY. Examine votes on chain with delegation and defa…

f9e385b

…ult delegate.

mint tokens to a given address when deployed

56e58a4

BecomeDefaultDelegate manually

79dfa84

GetDefaultDelegateBalance

55bc1bc

vote[proposal_id][from_account] == True/False;

b8680cf

Preliminarily tested convenient method CountVote; robust method `Is…

86b79a6

…ValidDelegate`

Hecate2 force-pushed the BurgerGov branch from 84e9539 to 86b79a6 Compare November 5, 2021 03:12

Let ExecuteProposal reuse CountVote if no voter list provided

139527d

More robust and efficient CountVote and ExecuteProposal

8fd4515

Hecate2 force-pushed the BurgerGov branch from 7538fbf to 8fd4515 Compare November 5, 2021 04:01

Hecate2 added 2 commits November 5, 2021 13:06

Attempt to regularize keys to raw bytes

8bd71d4

vote couting logic: I voted || I have valid delegate and delegate vot…

db4d4b5

…ed || I have invalid delegate but default delegate voted

Hecate2 and others added 8 commits November 5, 2021 16:22

optimized GetVotersOfProposal and CountVote using FindOptions

c47cb40

arg count starts from 0; optimzed GAS with args[(uint)j]

5929488

clearer exceptions

6abfa3c

Update NeoBurgerGovernanceToken.cs

807cb15

proposal attributes stored as structs

f17807c

Merge branch 'neoburger:main' into BurgerGov

ada94f2

Merge branch 'main' of github.com:Hecate2/code into BurgerGov

85c96c2

Merge branch 'BurgerGov' of github.com:Hecate2/code into BurgerGov

5be7f74

Hecate2 and others added 6 commits November 8, 2021 15:53

check voting deadline in refactored storage

a9d0ec5

method GetNextProposalID

0b662d0

proposal id given by user

623ed81

robust check for NewProposal

0aae44f

fix method Vote

95db3f7

Update NeoBurgerGovernanceToken.cs

525c015

vang1ong7ang reviewed Nov 8, 2021

View reviewed changes

Hecate2 added 4 commits November 9, 2021 09:38

leave VOTING_PERIOD a readonly const

149ddee

initially set readonly byte[] for prefixes

2ed8b81

remove useless if (voting_deadline == 0)

95c7b87

use const instead of bytearray

bed3983

Hecate2 force-pushed the BurgerGov branch from 7616348 to bed3983 Compare November 9, 2021 09:51

Conversation

Hecate2 commented Nov 4, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vang1ong7ang commented Nov 4, 2021

Uh oh!

Hecate2 commented Nov 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vang1ong7ang commented Nov 4, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Hecate2 commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hecate2 commented Nov 5, 2021

Uh oh!

Hecate2 commented Nov 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Hecate2 commented Nov 4, 2021 •

edited

Loading

Hecate2 commented Nov 5, 2021 •

edited

Loading

Hecate2 commented Nov 8, 2021 •

edited

Loading