Skip to content

feat: improve e2e framework and implement key_resharing, cancellation_of_resharing tests#2761

Open
anodar wants to merge 2 commits intoanodar/tests_basic_testsfrom
anodar/tests_resharing
Open

feat: improve e2e framework and implement key_resharing, cancellation_of_resharing tests#2761
anodar wants to merge 2 commits intoanodar/tests_basic_testsfrom
anodar/tests_resharing

Conversation

@anodar
Copy link
Copy Markdown
Collaborator

@anodar anodar commented Apr 8, 2026

Work towards: #2684

Tests ported from pytest:

  • key_resharing: 4 resharing rounds (expand, shrink, re-add, threshold increase)
  • cancellation_of_resharing: cancel stalled resharing, verify epoch tracking, retry with fresh node

…g tests

Framework:
- Options pattern for setup_cluster, shared test helpers in common.rs
- Full resharing suite: begin_resharing with attestation wait, epoch ID fix,
  participant ID preservation, participants-first voting, client_for_voting
- vote_cancel_resharing_from, reset_and_start_nodes, reset_mpc_state
- build-contract-wasm cargo make task, nextest e2e test group

Tests ported from pytest:
- key_resharing: 4 resharing rounds (expand, shrink, re-add, threshold increase)
- cancellation_of_resharing: cancel stalled resharing, verify epoch tracking,
  retry with fresh node
@anodar anodar marked this pull request as ready for review April 8, 2026 17:31
@claude
Copy link
Copy Markdown

claude bot commented Apr 8, 2026

PR title type suggestion: This PR changes only test files, so the type prefix should probably be test: instead of feat:.

Suggested title: test: improve e2e framework and implement key_resharing, cancellation_of_resharing tests

@claude
Copy link
Copy Markdown

claude bot commented Apr 8, 2026

Code Review

Reviewed the two new e2e test files (key_resharing.rs, cancellation_of_resharing.rs).

No critical issues found. The tests are well-structured, properly use unique port seeds, and follow project conventions for test code (raw arithmetic, panics for assertions). The resharing and cancellation flows are thoroughly exercised with liveness checks after each state transition.

Minor (non-blocking): send_sign_request and send_ckd_request helpers are duplicated between the two files — could be consolidated into common.rs if more tests need them.

✅ Approved

@claude
Copy link
Copy Markdown

claude bot commented Apr 8, 2026

PR title type suggestion: This PR changes only test files, so the type prefix should probably be test: instead of feat:.

Suggested title: test: improve e2e framework and implement key_resharing, cancellation_of_resharing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant