Skip to content

Add hoss-opendap-url output option to VOSS config in production.#886

Merged
chris-durbin merged 2 commits intomainfrom
add-hoss-url-option-to-voss-prod
Apr 1, 2026
Merged

Add hoss-opendap-url output option to VOSS config in production.#886
chris-durbin merged 2 commits intomainfrom
add-hoss-url-option-to-voss-prod

Conversation

@lyonthefrog
Copy link
Copy Markdown
Contributor

@lyonthefrog lyonthefrog commented Apr 1, 2026

Jira Issue ID

DAS-2448

Description

We forgot to add the hoss-opendap-url option to the VOSS configuration in Production

Local Test Steps

Does anyone know how to test that this notebook will work in production, or can you eyeball it and know whether or not it the appropriate changes have been made?
hoss-2445-final-notebook.zip
Previously it gave the following error that should now produce valid happy output:

Error: the requested combination of operations: variable subsetting and reformatting to application/x-netcdf4;profile=opendap_url on C2264134168-GES_DISC is unsupported
[sqs      ] Error calling Lambda: submitHarmonyOrder Error: Error: the requested combination of operations: variable subsetting and reformatting to application/x-netcdf4;profile=opendap_url on C2264134168-GES_DISC is unsupported

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)
  • Harmony in a Box tested (if changes made to microservices or new dependencies added)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

📝 Walkthrough

Walkthrough

Two YAML service configuration files were updated to expand output format support and clarify service descriptions. The production config adds application/x-netcdf4;profile=opendap_url as a supported output format for the variable-only-opendap-subsetter service, and both configs remove outdated descriptive text from the sds/hoss-opendap-url service.

Changes

Cohort / File(s) Summary
Production Service Configuration
config/services-prod.yml
Added application/x-netcdf4;profile=opendap_url to the variable-only-opendap-subsetter service's output_formats list; removed constraint language from sds/hoss-opendap-url service description regarding L3 GES DISC collections usage.
UAT Service Configuration
config/services-uat.yml
Simplified sds/hoss-opendap-url service description by removing the sentence about L3 GES DISC collection limitations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • indiejames
  • ygliuvt
  • chris-durbin

Poem

🐰 A format blooms in config's spring,
NetCDF now wears a second wing,
Old constraints fade from worn descriptions bright,
Our services dance in OPeNDAP light!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding the hoss-opendap-url output option to the VOSS production configuration, which aligns with the actual file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description includes all required template sections with the Jira issue ID, description of changes, local test steps, and a completed acceptance checklist.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-hoss-url-option-to-voss-prod

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
config/services-prod.yml (1)

235-243: ⚠️ Potential issue | 🔴 Critical

Critical: Missing 'reformat' operation for OPeNDAP URL format.

The production configuration adds application/x-netcdf4;profile=opendap_url to the supported output formats, but the operations list at line 243 only includes ['variableSubset']. The UAT configuration (line 353) correctly includes ['variableSubset','reformat'].

Since application/x-netcdf4;profile=opendap_url is a reformatting operation, the HOSS image step must declare 'reformat' in its operations list. Without this, Harmony won't route reformatting requests to this service, and the fix for the error mentioned in the PR description will not work.

🔧 Proposed fix
       - image: !Env ${HOSS_IMAGE}
-        operations: ['variableSubset']
+        operations: ['variableSubset','reformat']
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@config/services-prod.yml` around lines 235 - 243, The HOSS step in the
production config declares output_formats including
"application/x-netcdf4;profile=opendap_url" but its steps block (the HOSS image
entry with operations=['variableSubset']) is missing the 'reformat' operation;
update the HOSS image step's operations list to include 'reformat' (i.e.,
operations: ['variableSubset','reformat']) so requests for the OPeNDAP URL
profile will be routed to the HOSS service for reformatting.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@config/services-prod.yml`:
- Around line 235-243: The HOSS step in the production config declares
output_formats including "application/x-netcdf4;profile=opendap_url" but its
steps block (the HOSS image entry with operations=['variableSubset']) is missing
the 'reformat' operation; update the HOSS image step's operations list to
include 'reformat' (i.e., operations: ['variableSubset','reformat']) so requests
for the OPeNDAP URL profile will be routed to the HOSS service for reformatting.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3748d844-3e9e-4286-b490-828900a5d9e0

📥 Commits

Reviewing files that changed from the base of the PR and between 7e19a63 and 146d09a.

📒 Files selected for processing (2)
  • config/services-prod.yml
  • config/services-uat.yml

Copy link
Copy Markdown
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine - once I merge in the build fix I'll update this branch and then the tests should pass.

@chris-durbin chris-durbin merged commit c3cf383 into main Apr 1, 2026
6 checks passed
@chris-durbin chris-durbin deleted the add-hoss-url-option-to-voss-prod branch April 1, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants