refactor!: derive credentials path from config#647
Merged
Conversation
Contributor
📝 Changelog previewBelow is a preview of the Changelog that will be added to the next release. Only commit messages that follow the Conventional Commits specification will be included in the Changelog. v5.0.0 - 2026-02-18Full Changelog: v4.0.0...v5.0.0 ⚙️ Miscellaneous Changes
|
The credentials file path was independently computing the config directory using os.UserConfigDir() with a Darwin/XDG override, duplicating logic already handled by naistrix. Now derives the path from the global --config flag, ensuring credentials are always stored alongside the config file. This XDG_CONFIG_DIR overriding for macos created edge cases where IDE's launched nais cli without the same env vars as the users shell. If you have use-cases where you need nais cli to store it's config in a specific location and you used XDG_CONFIG_DIR before, you now have to use the --config flag instead.
sechmann
force-pushed
the
config_handling
branch
from
8304d21 to
28d83cb
Compare
sechmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The credentials file path was independently computing the config directory
using os.UserConfigDir() with a Darwin/XDG override, duplicating logic
already handled by naistrix. Now derives the path from the global --config
flag, ensuring credentials are always stored alongside the config file.
This XDG_CONFIG_DIR overriding for macos created edge cases where IDE's
launched nais cli without the same env vars as the users shell.
If you have use-cases where you need nais cli to store it's config in a
specific location and you used XDG_CONFIG_DIR before, you now have to
use the --config flag instead.