fix(mcp): Use typed input and outputs in the mcp server#625
Merged
thokra-nav merged 2 commits intomainfrom Dec 19, 2025
Merged
Conversation
Modern LLMs requires full json schema for MCP tools
Contributor
📝 Changelog previewBelow is a preview of the Changelog that will be added to the next release. Only commit messages that follow the Conventional Commits specification will be included in the Changelog. v3.25.1 - 2025-12-19Full Changelog: v3.25.0...v3.25.1 🐛 Bug Fixes
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the MCP server implementation by migrating from untyped map-based tool schemas to fully typed input/output structures. Modern LLMs require complete JSON schemas for MCP tools, and this change provides compile-time type safety and automatic schema generation.
Key changes:
- Introduced strongly-typed input and output structures for all 12 MCP tools
- Replaced manual parameter extraction with automatic deserialization via
NewStructuredToolHandlerandNewTypedToolHandler - Converted error handling from
mcp.NewToolResultErrorto standard Go error returns
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| internal/mcp/tools/types.go | New file defining typed input/output structures for all schema exploration and GraphQL execution tools |
| internal/mcp/tools/schema.go | Refactored 9 schema tool handlers to use typed inputs/outputs, removed manual JSON marshaling helper |
| internal/mcp/tools/graphql.go | Updated 3 GraphQL tool handlers with typed parameters and cleaner error handling |
| internal/mcp/tools/schema_test.go | Updated test to validate typed field formatting instead of map-based output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern LLMs requires full json schema for MCP tools