cmake/protobuf.cmake: add pkgconf option to WITH_PROTOBUF#650
Open
juchem wants to merge 1 commit intomysql:trunkfrom
Open
cmake/protobuf.cmake: add pkgconf option to WITH_PROTOBUF#650juchem wants to merge 1 commit intomysql:trunkfrom
pkgconf option to WITH_PROTOBUF#650juchem wants to merge 1 commit intomysql:trunkfrom
Conversation
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building
mysqland its dependencies from source and statically linking toprotobuf, the latter's dependencies are not automatically pulled in bycmake.In order to avoid breaking existing functionality of
WITH_PROTOBUF=systemwhile still allowing forpkg-configto do its job, this PR adds a new valueWITH_PROTOBUF=pkgconfto properly leveragepkg-configto find dependencies.