fix: pass hash as URL param instead of query#221
Open
Jerricho93 wants to merge 1 commit intomuxinc:mainfrom
Open
fix: pass hash as URL param instead of query#221Jerricho93 wants to merge 1 commit intomuxinc:mainfrom
Jerricho93 wants to merge 1 commit intomuxinc:mainfrom
Conversation
|
@Jerricho93 is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #216
Changes the unlisted video hashes in VImeo to be passed as a URL param instead of query param
Note
Low Risk
Low risk, isolated URL serialization change for Vimeo event embeds that only affects how unlisted hashes (
h) are formatted.Overview
Fixes Vimeo event embed URL generation so unlisted hashes are placed in the URL path (
/embed/<hash>) instead of the query string. This keepshin the query for standard video embeds, but removes it fromparamswhen building event URLs.Written by Cursor Bugbot for commit 69126e8. This will update automatically on new commits. Configure here.