[core] Add searchParams support to navigation items#5129
Open
jayenashar wants to merge 2 commits intomui:masterfrom
Open
[core] Add searchParams support to navigation items#5129jayenashar wants to merge 2 commits intomui:masterfrom
jayenashar wants to merge 2 commits intomui:masterfrom
Conversation
This change adds the ability to specify search parameters for navigation items, addressing user requests to include query strings in navigation links. Key changes: - Add optional searchParams property to NavigationPageItem interface - Update Link component to preserve search params and hash during navigation - Implement hierarchical searchParams merging in navigation path building - Child items inherit parent searchParams by default - Child items can override specific parent parameters - Empty URLSearchParams clears all inherited parameters - matchPath now matches on pathname only, ignoring search params for correct active page detection The implementation provides explicit control over search parameters while supporting inheritance patterns. This allows developers to define search parameters at parent levels that cascade to children, with children able to override or clear those parameters as needed. Fixes mui#4537
Add documentation for the new searchParams feature in navigation items, including usage examples and key behaviors for parameter inheritance, overriding, and clearing.
Member
|
I strongly advise against opening pull requests in this repository, at the moment the team doesn't have the bandwidth to review them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for search parameters in Toolpad navigation items, addressing #4537.
Changes
searchParamsproperty toNavigationPageItem: Navigation items can now specify URL search parametersmatchPathnow correctly matches on pathname only, ignoring search params for active page detectionAPI Usage
Implementation Details
URLSearchParams()clears all inherited parametersTesting
Documentation
Added a new section "Navigation with search parameters" to the Dashboard Layout documentation with usage examples and key behaviors.
Closes #4537