DB version > always bump on CI

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the database versioning process to ensure that the database version is consistently incremented, particularly within Continuous Integration (CI) workflows. The primary goal is to prevent scenarios where the database version might remain unchanged due to identical last modified dates, thereby guaranteeing that each new build in a CI environment correctly reflects an updated database.

Highlights

• Enhanced DB Versioning Logic: The bumpDBVersion method was updated to include a fileBase parameter, enabling more granular control over version increments.
• Forced CI Version Bump: New logic was introduced to ensure the database version is always incremented in Continuous Integration (CI) environments when processing "current_" files, preventing stale versions.
• Code Readability Improvements: Several variable names related to dates and versions were refactored for improved clarity and consistency.

Changelog

• src/main/java/org/mtransit/parser/mt/MGenerator.java
  • Modified the bumpDBVersion method signature to accept a new fileBase parameter.
  • Updated the call site for bumpDBVersion to pass the fileBase argument.
  • Implemented conditional logic within bumpDBVersion to force an increment of the database version when running in a CI environment and the fileBase is "current_".
  • Renamed lastModifiedTimeDateS to lastModifiedDateS and currentRdsDbVersion to currentRdsDbVersionS for better clarity.
  • Adjusted the logic for handling the length of the version string by multiplying the integer value by 10 instead of appending '0' to a string.

Activity

• No specific activity was provided for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces changes to the bumpDBVersion method in MGenerator.java. The method now accepts a fileBase parameter, which is used to implement a new logic that forces a database version bump on CI environments when the fileBase is "current_". This ensures that the DB version is always incremented in such scenarios. Additionally, several variable names have been refactored for improved clarity, and the final keyword has been applied to some variables, enhancing code readability and immutability. The logic for incrementing the database version by appending a '0' has been correctly updated to use integer multiplication, which is more appropriate for numerical versioning. Overall, the changes improve the robustness and clarity of the DB versioning process, especially within CI workflows.