feat (audience match types): Update audience evaluator and project config#56
Open
rashidsp wants to merge 9 commits intorashid/audience-match-types-condition-evaluatorfrom
Conversation
…nfig for new audience match types
Pull Request Test Coverage Report for Build 535
💛 - Coveralls |
oakbani
requested changes
Dec 11, 2018
Collaborator
oakbani
left a comment
There was a problem hiding this comment.
Optimizely Typed Audience Tests are missing.
See them here: https://github.com/optimizely/python-sdk/pull/147/files#diff-35022a0711117ec71e5cef204d5d5e89
…ashid/audience-match-type-project-config
…ashid/audience-match-type-project-config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates project config and the audience evaluator to finish the implementation of typed audience evaluation:
falsewhen no attributes were passed)Test Plan
New & existing unit tests
Ran compatibility suite tests for typed audiences