Skip to content

fix(sftp): flush synchronously added requests during connection cleanup #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffrson wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −10
Open

fix(sftp): flush synchronously added requests during connection cleanup #1491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions lib/protocol/SFTP.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2721,17 +2721,18 @@ function doFatalSFTPError(sftp, msg, noDebug) {
}

function cleanupRequests(sftp) {
const keys = Object.keys(sftp._requests);
if (keys.length === 0)
return;

const reqs = sftp._requests;
sftp._requests = {};
const err = new Error('No response from server');
for (let i = 0; i < keys.length; ++i) {
const req = reqs[keys[i]];
if (typeof req.cb === 'function')
req.cb(err);
while (true) {
const keys = Object.keys(sftp._requests);
if (keys.length === 0)
return;
const reqs = sftp._requests;
sftp._requests = {};
for (let i = 0; i < keys.length; ++i) {
const req = reqs[keys[i]];
if (typeof req.cb === 'function')
req.cb(err);
}
}
}

Expand Down