Conversation
This was referenced Dec 6, 2025
Splines
pushed a commit
to MaMpf-HD/mampf
that referenced
this pull request
Dec 6, 2025
connection_pool is a gem needed by Activesupport. In its 3.0 release, connection_pool introduced breaking changes in the signature of the initialize function (see this [PR](mperham/connection_pool#209)) that break activesupport resulting in the error: ArgumentError: wrong number of arguments (given 1, expected 0) (ArgumentError) during build. Therefore we should currently limit connection_pool to versions before 3.0, until this is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionPoolis mostly safe for upgrades as the basic API is compatible.ConnectionPool::TimedStackis not compatible.Thanks to @ruyrocha for some of the work in #206