Static-link s390x and riscv64 musl; Add static-link check#2658
Open
Xeonacid wants to merge 1 commit intomozilla:mainfrom
Open
Static-link s390x and riscv64 musl; Add static-link check#2658Xeonacid wants to merge 1 commit intomozilla:mainfrom
Xeonacid wants to merge 1 commit intomozilla:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CI build matrix to better ensure Linux musl artifacts are truly statically linked, aligning the produced binaries with the “portable binary” promise in the README.
Changes:
- Adds
-Ctarget-feature=+crt-staticfors390x-unknown-linux-muslandriscv64gc-unknown-linux-muslbuilds. - Introduces a CI step that inspects musl build artifacts for dynamic dependencies via
readelf.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xeonacid
force-pushed
the
copilot/fix-sccache-linking-issues
branch
from
bfe3714 to
6041201
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it a "portable binary" as stated in README.
Ref: rust-lang/rust@9c37c14